Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/api_management_user - updating the username validation #7975

Merged
merged 6 commits into from
Aug 10, 2020
Merged

d/api_management_user - updating the username validation #7975

merged 6 commits into from
Aug 10, 2020

Conversation

rikribbers
Copy link
Contributor

@rikribbers rikribbers commented Jul 31, 2020

I fixed the retrieval of admin user.

Rationale for the fix:

I interpreted that the user_id field is the user identifier and not the full Azure resource id. The MS docs state that is the "User identifier" and it is unique within the current APIM instance. The type is string.

https://docs.microsoft.com/en-us/rest/api/apimanagement/2019-12-01/user/get

Fixes #3967

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @rikribbers

Thanks for this PR :)

Taking a look through here, is it possible to give an example of the username which is being rejected here? Based on what I can see in the validation code we're validating for a 3-80 character username, rather than a Resource ID - so I'm wondering if we need to update this regex instead?

Thanks!

@rikribbers
Copy link
Contributor Author

ok, I understand the tradeoff that was made here.. was thinking about using a regex like this:

^(?!.*-$)^[a-z][a-z-]{0,79}$

However this uses a negative lookup that is not supported by go. So second best is to go for a length of 2:

^[a-zA-Z0-9])([a-zA-Z0-9-]{0,78})([a-zA-Z0-9]$

Or split the check up into 2 steps, one for starting and ending with a '-' character and a allowed character regex : ^[a-zA-Z0-9-]{1,80}

I could use some advice on what to implement. I prefer the last one. as this resembles the actual behaviour from the portal.

@ghost ghost removed the waiting-response label Aug 6, 2020
@katbyte
Copy link
Collaborator

katbyte commented Aug 6, 2020

Hey @rikribbers - the 2nd option would be fine :)

@tombuildsstuff tombuildsstuff changed the title fix for #3967 r/api_management_user - updating the username validation Aug 10, 2020
@tombuildsstuff tombuildsstuff changed the title r/api_management_user - updating the username validation d/api_management_user - updating the username validation Aug 10, 2020
@tombuildsstuff tombuildsstuff added this to the v2.23.0 milestone Aug 10, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @rikribbers

@tombuildsstuff tombuildsstuff merged commit 226f12b into hashicorp:master Aug 10, 2020
tombuildsstuff added a commit that referenced this pull request Aug 10, 2020
@ghost
Copy link

ghost commented Aug 13, 2020

This has been released in version 2.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants